Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/6648#discussion_r33701929 --- Diff: core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockResolver.scala --- @@ -23,6 +23,8 @@ import java.util.concurrent.atomic.AtomicInteger import scala.collection.JavaConversions._ +import com.google.common.annotations.VisibleForTesting --- End diff -- Ok, that's cool. I just wasn't paying enough attention to be aware of when this new practice was introduced. I'm in favor of it as long as it is standard practice.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org