Github user HuJiayin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7208#discussion_r33926169
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -165,6 +165,20 @@ public UTF8String toLowerCase() {
return UTF8String.fromString(toString().toLowerCase());
}
+ public UTF8String initCap(final byte[] byteArr) {
+ if (byteArr == null) return null;
+ if (byteArr[0] <= 122 && byteArr[0] >= 97) //a-z
--- End diff --
Europe language is not supported in this method. It is not supported in
Java StringBuilder toUpper function.
Since few words start with the special characters, and this kind of
characters canbe converted in to English letters, for example ö => oe , so I
think your suggestions will not be accepted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
