Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7208#discussion_r33946831 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -298,3 +299,34 @@ case class StringLength(child: Expression) extends UnaryExpression with ExpectsI override def prettyName: String = "length" } + +/** + * Returns string, with the first letter of each word in uppercase, + * all other letters in lowercase. Words are delimited by whitespace. + */ +case class InitCap(child: Expression) extends UnaryExpression with ExpectsInputTypes { + override def dataType: DataType = StringType + override def inputTypes: Seq[DataType] = Seq(StringType) + override def eval(input: InternalRow): Any = { + val string = child.eval(input) + if (string == null) { + null + } else { + val str: String = string.toString + if (str == "") { + return null + } + val sb = new StringBuilder + sb.append(str) + sb.setCharAt(0, sb(0).toUpper) + --- End diff -- old comment: This crashes if `str = ""` (in outdated diff) ```` scala> val sb = new StringBuilder; sb.append(""); sb.setCharAt(0, sb(0).toUpper) java.lang.StringIndexOutOfBoundsException: String index out of range: 0 at java.lang.AbstractStringBuilder.charAt(AbstractStringBuilder.java:210) at java.lang.StringBuilder.charAt(StringBuilder.java:76) at scala.collection.mutable.StringBuilder.apply(StringBuilder.scala:117) ... 33 elided ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org