Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6938#discussion_r34223502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -600,3 +604,146 @@ case class Logarithm(left: Expression, right: Expression) """ } } + +case class Round(child: Expression, scale: Expression) extends Expression with ExpectsInputTypes { --- End diff -- can you make this a binary expression? and just do ``` override def left: Expression = child override def right: Expression = scale ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org