Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34223608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression, right:
Expression)
"""
}
}
+
+case class Round(child: Expression, scale: Expression) extends Expression
with ExpectsInputTypes {
+
+ def this(child: Expression) = {
+ this(child, Literal(0))
+ }
+
+ override def children: Seq[Expression] = Seq(child, scale)
+
+ override def nullable: Boolean = true
+
+ override def foldable: Boolean = child.foldable
+
+ override lazy val dataType: DataType = child.dataType match {
+ case DecimalType.Fixed(p, s) => DecimalType(p, _scale)
+ case t => t
+ }
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(
+ // rely on precedence to implicit cast String into Double
+ TypeCollection(DecimalType, DoubleType, FloatType, LongType,
IntegerType, ShortType, ByteType),
+ TypeCollection(LongType, IntegerType, ShortType, ByteType))
--- End diff --
the 2nd argument should just be an IntegerType. It will get implicitly
casted anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
