Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7004#discussion_r34585605
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -160,6 +162,21 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
         set("spark.serializer", classOf[KryoSerializer].getName)
         this
       }
    +  /**
    +   * Use Kryo serialization and register the given set of Avro schemas so 
that the generic
    +   * record serializer can decrease network IO
    +   */
    +  def registerAvroSchema(schemas: Array[Schema]): SparkConf =
    --- End diff --
    
    how about using varargs here? `def registerAvroSchema(schemas: Schema*): 
SparkConf`
    
    then you could call using any of:
    ```
    registerAvroSchema(schema)
    registerAvroSchema(schemaOne, schemaTwo, schemaThree)
    registerAvroSchema(schemaSeq: _*) // works w/ an array too
    ```
    
    and maybe rename the method to plural, `registerAvroSchemas`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to