Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-121294001
Is it important to use ZLIB as opposed to one of the other compression
libraries we already have? Is that how we get better compression? Its just a
bit of a burden for code maintainers to learn, if say LZ4 works just as well,
when we've already got it wrapped up in one of spark's `CompressionCodec` so
the usage is standard. Eg., I'm not familiar w/ the `Deflater`, and your usage
isn't exactly the same as the simple example in the javadoc:
http://docs.oracle.com/javase/7/docs/api/java/util/zip/Deflater.html so its a
bit more work to make sure the usage is correct, its getting cleaned up, etc.
If it provides some advantage, that is fine, but just want to make sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
