Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7580#discussion_r35294372
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -35,3 +36,47 @@ case class Size(child: Expression) extends 
UnaryExpression with ExpectsInputType
         nullSafeCodeGen(ctx, ev, c => s"${ev.primitive} = ($c).size();")
       }
     }
    +
    +case class ArrayContains(left: Expression, right: Expression) extends 
BinaryExpression with ExpectsInputTypes {
    +  override def dataType: DataType = BooleanType
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(ArrayType, 
AnyDataType)
    --- End diff --
    
    Overriding the `checkInputDataTypes()` will provide more readable message 
once the data type is not as the expected, otherwise, it probably throws 
exception in the code snippet that I showed above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to