Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35294590
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +36,47 @@ case class Size(child: Expression) extends
UnaryExpression with ExpectsInputType
nullSafeCodeGen(ctx, ev, c => s"${ev.primitive} = ($c).size();")
}
}
+
+case class ArrayContains(left: Expression, right: Expression) extends
BinaryExpression with ExpectsInputTypes {
+ override def dataType: DataType = BooleanType
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(ArrayType,
AnyDataType)
--- End diff --
Just be sure we are in the same page, the second dataType should be
identical with the inner type of the ArrayType (first dataType).
`bigint`(LongType) is not acceptable, if the dataType of first argument is
ArrayType(IntegerType, _), but NullType will be OK, as the `NullType` is
implicit acceptable for all of the expected data types.
It will be nice if you can try that in the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
