Github user lirui-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r13421524
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -738,4 +739,13 @@ private[spark] class TaskSetManager(
         logDebug("Valid locality levels for " + taskSet + ": " + 
levels.mkString(", "))
         levels.toArray
       }
    +
    +  // Re-compute the pending lists. This should be called when new executor 
is added
    +  def reAddPendingTasks() {
    +    logInfo("Re-computing pending task lists.")
    +    for (i <- (0 until numTasks).reverse.filter(index => 
copiesRunning(index) == 0
    --- End diff --
    
    Actually this is the same filter used in "findTaskFromList". TaskSetManager 
will re-add failed task to pending lists, so it can have the updated executor 
availability. For speculative task, TaskSetManager won't check the availability 
of executors in "findSpeculativeTask". Please correct me if I misunderstand 
anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to