Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r13451805
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -738,4 +750,20 @@ private[spark] class TaskSetManager(
         logDebug("Valid locality levels for " + taskSet + ": " + 
levels.mkString(", "))
         levels.toArray
       }
    +
    +  // Re-compute pendingTasksWithNoPrefs since new preferred locations may 
become available
    +  def executorAdded() {
    +    def newLocAvail(index: Int): Boolean = {
    +      for (loc <- tasks(index).preferredLocations) {
    +        if (sched.hasExecutorsAliveOnHost(loc.host) ||
    +          (loc.executorId.isDefined && 
sched.isExecutorAlive(loc.executorId.get)) ||
    --- End diff --
    
    Similar to above, I think this line is redundant with the previous one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to