Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6339#discussion_r35581847 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -151,4 +167,64 @@ class StringIndexerModel private[ml] ( val copied = new StringIndexerModel(uid, labels) copyValues(copied, extra) } + + /** + * Return a model to perform the inverse transformation. + * Note: by default we keep the original columns during this transformation --- End diff -- This is confusing. How about writing: ``` Note: By default we keep the original columns during this transformation, so the inverse should only be used on new columns such as predicted labels. ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org