Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6339#discussion_r35615170
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -151,4 +167,64 @@ class StringIndexerModel private[ml] (
         val copied = new StringIndexerModel(uid, labels)
         copyValues(copied, extra)
       }
    +
    +  /**
    +   * Return a model to perform the inverse transformation.
    +   * Note: by default we keep the original columns during this 
transformation
    +   * so the invert should only be needed if you do something beyond simply
    +   * applying the original transformation.
    +   */
    +  def invert(): StringIndexerInvertModel = {
    +    new StringIndexerInvertModel(uid, labels)
    --- End diff --
    
    I wasn't super sure what to set the parent too. Should we make 
StringIndexerModel an estimator then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to