Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7191#discussion_r35901019
  
    --- Diff: dev/run-tests.py ---
    @@ -266,6 +266,7 @@ def get_hadoop_profiles(hadoop_version):
             "hadoop2.0": ["-Phadoop-1", "-Dhadoop.version=2.0.0-mr1-cdh4.1.1"],
             "hadoop2.2": ["-Pyarn", "-Phadoop-2.2"],
             "hadoop2.3": ["-Pyarn", "-Phadoop-2.3", "-Dhadoop.version=2.3.0"],
    +        "hadoop2.6": ["-Pyarn", "-Phadoop-2.6", "-Dhadoop.version=2.6.0"],
    --- End diff --
    
    minor nit, and I see you're just following the pattern, but the profile 
should already set `hadoop.version`, so re-stating it here is redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to