Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7191#discussion_r35911575
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -1251,7 +1265,8 @@ 
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
           InsertIntoTable(UnresolvedRelation(tableIdent, None), partitionKeys, 
query, overwrite, true)
     
         case a: ASTNode =>
    -      throw new NotImplementedError(s"No parse rules for:\n 
${dumpTree(a).toString} ")
    +      throw new NotImplementedError(s"No parse rules for ${a.getName}:" +
    +          s"\n ${dumpTree(a).toString} ")
    --- End diff --
    
    not your code, but `toString` looks redundant here. (Then maybe it all fits 
in one line?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to