Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7862#discussion_r36040528
--- Diff:
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineSuite.scala
---
@@ -73,11 +73,11 @@ class PersistenceEngineSuite extends SparkFunSuite {
assert(persistenceEngine.read[String]("test_").isEmpty)
// Test deserializing objects that contain RpcEndpointRef
- val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, new
SecurityManager(conf))
+ val testRpcEnv = RpcEnv.create("test", "localhost", 12345, conf, new
SecurityManager(conf))
try {
// Create a real endpoint so that we can test RpcEndpointRef
deserialization
- val workerEndpoint = rpcEnv.setupEndpoint("worker", new RpcEndpoint {
- override val rpcEnv: RpcEnv = rpcEnv
+ val workerEndpoint = testRpcEnv.setupEndpoint("worker", new
RpcEndpoint {
+ override val rpcEnv: RpcEnv = testRpcEnv
--- End diff --
`rpcEnv` was apparently just calling itself here according to the compiler,
so renamed the reference to avoid conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
