Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7862#discussion_r36040593
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaWriteAheadLogSuite.java
---
@@ -17,13 +17,15 @@
package org.apache.spark.streaming;
+import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.nio.ByteBuffer;
import java.util.Arrays;
-import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
-import org.apache.commons.collections.CollectionUtils;
-import org.apache.commons.collections.Transformer;
+import com.google.common.base.Function;
--- End diff --
There were a few actual warnings fixed up here, but I think this file
needed a fair bit of cleanup and I just did it:
- Get rid of single use of Commons Collections transformer methods in favor
of Guava
- `.java` files almost never have two top level classes
- Always set character encoding when converting strings to/from bytes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
