Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r37353473
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -208,6 +208,22 @@ case class ExecutorLostFailure(execId: String) extends 
TaskFailedReason {
     
     /**
      * :: DeveloperApi ::
    + * The task failed because the executor that it was running on was 
prematurely terminated. The
    + * executor is forcibly exited but the exit should be considered as part 
of normal cluster
    + * behavior.
    + */
    +@DeveloperApi
    +case class ExecutorNormalExit(
    --- End diff --
    
    I'd give the same feedback here, but then `ExecutorLostFailure` is a 
developer API... still I think that a single reason (with a boolean saying 
whether to treat it as an error) would be simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to