Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r37353932
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -809,9 +825,14 @@ private[spark] class TaskSetManager(
             }
           }
         }
    -    // Also re-enqueue any tasks that were running on the node
         for ((tid, info) <- taskInfos if info.running && info.executorId == 
execId) {
    -      handleFailedTask(tid, TaskState.FAILED, ExecutorLostFailure(execId))
    +      // Also re-enqueue any tasks that were running on the node
    +      val executorFailureReason = reason match {
    +        case exited: ExecutorExitedNormally =>
    --- End diff --
    
    This would go away if you follow my suggestion of merging the two errors, 
but in any case, since it's a case class:
    
        case ExecutorExitedNormally(exitCode, reason) =>
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to