Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132559067 I think the additional changes I mentioned are worth fixing here since they're very much of the same form. If you have time to scan for similar problems in nearby source, that's fine, but fixing all the related issues in this file seems like a good logical change.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org