Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556264
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -716,11 +735,14 @@ class DAGScheduler(
}
}
- /** Finds the earliest-created active job that needs the stage */
- // TODO: Probably should actually find among the active jobs that need
this
- // stage the one with the highest priority (highest-priority pool,
earliest created).
- // That should take care of at least part of the priority inversion
problem with
- // cross-job dependencies.
+ /**
+ * Finds the earliest-created active job that needs the stage.
+ *
+ * TODO: Probably should actually find among the active jobs that need
this
--- End diff --
I'm not sure all of this should be scaladoc. This looks like a private
comment in the source code. Same for "Broken out for easier testing..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
