Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556365
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1162,17 +1190,20 @@ class DAGScheduler(
}
case commitDenied: TaskCommitDenied =>
- // Do nothing here, left up to the TaskScheduler to decide how to
handle denied commits
+ // Do nothing here, left up to the TaskScheduler implementation
+ // to decide how to handle denied commits
case ExceptionFailure(className, description, stackTrace,
fullStackTrace, metrics) =>
- // Do nothing here, left up to the TaskScheduler to decide how to
handle user failures
+ // Do nothing here, left up to the TaskScheduler implementation
+ // to decide how to handle user failures
--- End diff --
Why was this changed? it's not a big deal, but it was OK on one line.
Changes always have this small but non-zero chance of tangling up a merge
later, so trivial changes are usually avoided
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
