Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8180#discussion_r37673081
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala ---
    @@ -37,6 +45,9 @@ private[spark] class ShuffleMapStage(
     
       override def toString: String = "ShuffleMapStage " + id
     
    +  /** Map-stage jobs that were submitted to execute this stage 
independently (if any) */
    --- End diff --
    
    can you expand that this only for jobs that that were submitted *just* for 
this stage?  Ie., it does *not* include jobs that indirectly depend on this 
stage. 
    Also, this is kinda obvious from the type, but do you mind expanding the 
comment to say that this only *running* jobs that were submitted for this job?  
So that if  job completes, its removed from this list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to