Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8180#discussion_r37678962
--- Diff: core/src/main/scala/org/apache/spark/MapOutputStatistics.scala ---
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+/**
+ * Holds statistics about the output sizes in a map stage. May become a
DeveloperApi in the future.
+ */
+private[spark] class MapOutputStatistics(val shuffleId: Int, val
bytesByPartitionId: Array[Long])
--- End diff --
can you add a comment to make it clear that `bytesByPartitionId` is indexed
by the shuffle-*read* aka reduce side? (at least, I think it is, if I'm
reading the code right.) Also probably worth adding a comment that this is
just an estimate of the size, and can really be off by an arbitrary amount
given the approximations made in `HighlyCompressedMapStatus`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
