Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/1104#discussion_r13897737
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -38,10 +38,10 @@ import org.apache.spark.mllib.linalg.{Vectors, Vector}
class LBFGS(private var gradient: Gradient, private var updater: Updater)
extends Optimizer with Logging {
- private var numCorrections = 10
- private var convergenceTol = 1E-4
- private var maxNumIterations = 100
- private var regParam = 0.0
+ private var numCorrections: Int = 10
+ private var convergenceTol: Double = 1E-4
+ private var maxNumIterations: Int = 100
+ private var regParam: Double = 0.0
--- End diff --
In most of the mllib codebase, we don't specify the type of variable. Can
you remove them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
