Github user BaiGang commented on the pull request: https://github.com/apache/spark/pull/1104#issuecomment-46393686 @dbtsai Thanks for looking into this PR. I've updated the code, removing the unnecessary type specifications for the vars in class LBFGS. Also I have a question. If I externally (outside mllib) make uses of LBFGS, should I use the object method LBFGS.runLBFGS(.) or create an instance of class LBFGS and run the optimize(.) method? Which one of the is the supposed proper usage of the LBFGS optimizer? As for the tests, I think we should just test against that usage.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---