Github user massie commented on the pull request:
https://github.com/apache/spark/pull/7403#issuecomment-138622760
@rxin and @andrewor14 - Is there anything more that needs to be done before
this PR is ready to be merged? I've made all recommended changes.
There is an open question about having the class names be (a) `public`
variables on a `Dependency` or (b) parameters passed to `registerShuffle`.
Option A would be better if we want in the future to see the `Dependency` tree
with all class types and option B is better if we don't want to have the class
names be `public`. Of course, option B would require a change to the
`ShuffleManager` API and this PR.
This PR is ready to go for Option A. Let me know your thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
