Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7403#issuecomment-139012865
@massie The changes here look fine. The only thing I'm still not sure about
is the fact that everything is public. You pointed out that `ShuffleDependency`
is `DeveloperApi`, but things like `combineByKeyWithClassTag` are not and are
fully public. My view is that if in the initial version of this patch we keep
as many things private, we can always expose more of these things gradually in
the future, but we can't go the other way. E.g. your other patch #7265 doesn't
require any of these things to be public.
Other than that, I don't have strong opinions one way or the other about
this patch. I think it's a good addition but I'm wary of the many public API
changes in this patch. If @rxin thinks it's in a good shape then we should
merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
