Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8658#discussion_r38985416
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -91,6 +91,17 @@ def _(self):
         return _
     
     
    +def _bin_func_op(name, reverse=False, doc="binary function"):
    --- End diff --
    
    If we are _just_ looking at adding pow then it might make more sense to add 
pow to column, but if we are looking at making it easy to access the rest of 
the functions in functions.scala this sounds good (although maybe add a tiny 
comment explaining the purpose).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to