Github user 0x0FFF commented on a diff in the pull request:
https://github.com/apache/spark/pull/8658#discussion_r39195144
--- Diff: python/pyspark/sql/column.py ---
@@ -151,6 +162,8 @@ def __init__(self, jc):
__rdiv__ = _reverse_op("divide")
__rtruediv__ = _reverse_op("divide")
__rmod__ = _reverse_op("mod")
+ __pow__ = _bin_func_op("pow")
--- End diff --
Agree. What if I replace
```
jc = other._jc if isinstance(other, Column) else float(other)
```
with
```
jc = other._jc if isinstance(other, Column) else
_create_column_from_literal(other)
```
Would it still worth renaming to `_pow`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
