Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8678#discussion_r39151883
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -901,7 +901,7 @@ class DAGScheduler(
// the stage as completed here in case there are no tasks to run
markStageAsFinished(stage, None)
- val debugString = stage match {
+ def debugString: String = stage match {
--- End diff --
Is this really expensive to compute? it doesn't look that heavy. But you
can already just pass the expression as the argument to `logDebug` and I think
it will be lazily evaluated? Only mostly sure about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
