Github user saucam commented on the pull request:
https://github.com/apache/spark/pull/8678#issuecomment-139331711
@andrewor14 for the "harder to read part" initially i had changed the val
to a def ; the rest was the same , I am sure it was not affecting the
readability if thats your concern here, but @srowen suggested to pass the
value directly (don;t know why)
I can revert it to my original change if you prefer that way.
"The reduce in delay is extremely negligible"
agreed! , but still it is there !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
