Github user 0x0FFF commented on the pull request:
https://github.com/apache/spark/pull/8658#issuecomment-139384669
Please, also check out the implementation from last commit. In my opinion
it is much more consistent. I just cannot implement `_pow` in `column.py`, it
looks much like a duck tape. General `_bin_func_op` function with converting
second parameter to `Column` type with `lit` call is better, but still in my
opinion the implementation from commit 40cbcb4 is much better - code is easier
to read, more consistent, and it is adding less code (only 4 lines, excluding
comment and tests)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
