Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8830#discussion_r40046365
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala ---
@@ -87,11 +129,17 @@ private[ml] case class ResolvedRFormula(label: String,
terms: Seq[String])
*/
private[ml] sealed trait Term
+/** A term that may be part of an interaction, e.g. 'x' in 'x:y' */
+private[ml] sealed trait InteractionComponent extends Term
+
/* R formula reference to all available columns, e.g. "." in a formula */
-private[ml] case object Dot extends Term
+private[ml] case object Dot extends InteractionComponent
/* R formula reference to a column, e.g. "+ Species" in a formula */
-private[ml] case class ColumnRef(value: String) extends Term
+private[ml] case class ColumnRef(value: String) extends
InteractionComponent
--- End diff --
This makes the implementation easier but code harder to understand, because
a `ColRef` is not an interaction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
