Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/8830#discussion_r40047935 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -31,20 +32,28 @@ private[ml] case class ParsedRFormula(label: ColumnRef, terms: Seq[Term]) { * of the special '.' term. Duplicate terms will be removed during resolution. */ def resolve(schema: StructType): ResolvedRFormula = { - var includedTerms = Seq[String]() + val dotTerms = expandDot(schema) + var includedTerms = Seq[Seq[String]]() terms.foreach { + case term: ColumnRef => + includedTerms :+= Seq(term.value) + case ColumnInteraction(terms) => --- End diff -- Done
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org