Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8953#discussion_r41345489
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/HashJoinNode.scala
---
@@ -24,19 +24,33 @@ import org.apache.spark.sql.execution.joins._
import org.apache.spark.sql.execution.metric.SQLMetrics
/**
+ * A node for inner hash equi-join. It can be used individually or wrapped
by other
+ * inner hash equi-join nodes such as [[BinaryHashJoinNode]]. This node
takes a already
+ * built [[HashedRelation]] and a [[LocalNode]] representing the streamed
side.
+ * If this node is used individually, `isWrapped` should be set to false.
+ * If this node is wrapped in another node, `isWrapped` should be set to
true
--- End diff --
As discussed offline, it might be better to put the common code in a trait
instead of wrapping local nodes. Right now it's kind of confusing because
sometimes we call `prepare` or `close` but sometimes we don't.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
