Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41345552 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/local/HashJoinNodeSuite.scala --- @@ -19,10 +19,12 @@ package org.apache.spark.sql.execution.local import org.apache.spark.sql.SQLConf import org.apache.spark.sql.catalyst.dsl.expressions._ -import org.apache.spark.sql.execution.joins.{BuildLeft, BuildRight, BuildSide} +import org.apache.spark.sql.catalyst.expressions.{UnsafeProjection, Expression} +import org.apache.spark.sql.execution.joins.{HashedRelation, BuildLeft, BuildRight, BuildSide} +import org.apache.spark.sql.test.SharedSQLContext -class HashJoinNodeSuite extends LocalNodeTest { +class HashJoinNodeSuite extends LocalNodeTest with SharedSQLContext { --- End diff -- where does this test use `SQLContext`? We made an effort to not introduce this dependency in an earlier patch so we should try to avoid the same here. #8764
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org