Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41454294 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -26,7 +26,10 @@ abstract class BaseMutableProjection extends MutableProjection /** * Generates byte code that produces a [[MutableRow]] object that can update itself based on a new - * input [[InternalRow]] for a fixed set of [[Expression Expressions]]. + * input [[InternalRow]] for a fixed set of [[Expression Expressions]]. It exposes a `target` + * method. This method is used to set the row that will be updated. So, when `target` is used, the + * [[MutableRow]] object created internally will not be used. If `target` is not used, the --- End diff -- This comment is quite verbose. I think you can just say ``` It exposes a `target` method, which is used to set the row that will be updated. The internal [[MutableRow]] object created internally is used only when `target` is not used. ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org