Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8953#discussion_r41454914
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/local/HashJoinNode.scala 
---
    @@ -73,10 +60,21 @@ case class HashJoinNode(
         }
       }
     
    +  /** Sets the HashedRelation used by this node. */
    +  protected def withHashedRelation(hashedRelation: HashedRelation): Unit = 
{
    +    hashed = hashedRelation
    +  }
    +
    +  /**
    +   * For nodes that extends this, they can use doOpen to add operations 
needed in the open method.
    --- End diff --
    
    I think just the following is good:
    `Custom open implementation to be overridden by subclasses.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to