Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41587282 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -608,6 +612,18 @@ private[spark] class ApplicationMaster( } } + /** set "SPARK_SHUFFLE_TOKEN" before registerAM + * @return + */ + private def initJobCredentialsAndUGI() = { --- End diff -- I mentioned this before but I don't believe this should be necessary. `Client` always runs before this and should be propagating the credentials to the AM. In fact, if somehow the secret generated by `Client` is not showing up here, you could have weird things happening in client mode, since the driver and the AM will have different secrets.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org