Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8880#issuecomment-146726420
Hi @winningsix,
I need to read the buffer handling code again, but it could use some
cleanup to make it easier to follow. Also, just pointing out style violations
that still are all over the code:
- always add parentheses to methods that are not simple getters
- methods should always declare the return type (i.e. do not use `def foo {
... }`)
- `else`, `catch`, and `finally` placement is consistently wrong.
- scaladoc does not use HTML tags
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
