Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9043#discussion_r41670365
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -585,6 +652,37 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
}
+ /**
+ * Checks whether HDFS is in safe mode. The API is slightly different
between hadoop 1 and 2,
+ * so we have to resort to ugly reflection (as usual...).
+ *
+ * Note that DistributedFileSystem is a `@LimitedPrivate` class, which
for all practical reasons
+ * makes it more public than not.
+ */
+ private[history] def isFsInSafeMode(): Boolean = {
+ if (!fs.isInstanceOf[DistributedFileSystem]) {
+ return false
+ }
+ isFsInSafeMode(fs.asInstanceOf[DistributedFileSystem])
+ }
+
+ // For testing.
+ private[history] def isFsInSafeMode(dfs: DistributedFileSystem): Boolean
= {
+ val hadoop1Class =
"org.apache.hadoop.hdfs.protocol.FSConstants$SafeModeAction"
+ val hadoop2Class =
"org.apache.hadoop.hdfs.protocol.HdfsConstants$SafeModeAction"
+ val actionClass: Class[_] =
+ try {
+ getClass().getClassLoader().loadClass(hadoop2Class)
+ } catch {
+ case _: ClassNotFoundException =>
+ getClass().getClassLoader().loadClass(hadoop1Class)
+ }
+
+ val action = actionClass.getField("SAFEMODE_GET").get(null)
+ val method = dfs.getClass().getMethod("setSafeMode", action.getClass())
+ method.invoke(dfs, action).asInstanceOf[Boolean]
--- End diff --
I am assuming this piece of code is correct. I have no idea why a set
method returns a `Boolean`, but who am I to argue with the Hadoop API
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
