Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9043#discussion_r41670523
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -170,7 +223,21 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
         }
       }
     
    -  override def getConfig(): Map[String, String] = Map("Event log 
directory" -> logDir.toString)
    +  override def getConfig(): Map[String, String] = {
    +    val safeMode = if (isFsInSafeMode()) {
    +      Map("HDFS State" -> "In safe mode.")
    --- End diff --
    
    This is only for testing I assume. Can you please add a comment stating 
that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to