Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9095#discussion_r41857332
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -395,6 +395,10 @@ private[yarn] class YarnAllocator(
val executorId = executorIdCounter.toString
assert(container.getResource.getMemory >= resource.getMemory)
--- End diff --
True, I mean, should we expect there is a case where the granted memory is
less than requested as well? and allow or handle it? right now it's rejected,
so I expect it can't happen. But then again the code seemed to assume that
(sort of) about vcores too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
