Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/9095#discussion_r41866472
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -395,6 +395,10 @@ private[yarn] class YarnAllocator(
val executorId = executorIdCounter.toString
assert(container.getResource.getMemory >= resource.getMemory)
--- End diff --
memory should never be less then requested. vcores support was added later
though and if its configured off or the scheduler doesn't support it then its
possible to get back less. Like mentioned the defaultResourceCalculator just
always returns 1.
There is already a comment on this at matchContainerToRequest. Is this
actually failing or you were just surprised at what you got?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
