Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8931#discussion_r42062981
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -40,7 +40,9 @@ case class TungstenAggregate(
override private[sql] lazy val metrics = Map(
"numInputRows" -> SQLMetrics.createLongMetric(sparkContext, "number of
input rows"),
- "numOutputRows" -> SQLMetrics.createLongMetric(sparkContext, "number
of output rows"))
+ "numOutputRows" -> SQLMetrics.createLongMetric(sparkContext, "number
of output rows"),
+ "dataSize" -> SQLMetrics.createSizeMetric(sparkContext, "data size"),
+ "spilledSize" -> SQLMetrics.createSizeMetric(sparkContext, "spilled
size"))
--- End diff --
I think this can just be `spill size`. If you change this then you should
also change all the variable names
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
