Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8931#discussion_r42065578
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -102,20 +96,53 @@ private object LongSQLMetricParam extends
SQLMetricParam[LongSQLMetricValue, Lon
override def zero(initialValue: LongSQLMetricValue): LongSQLMetricValue
= zero
- override def zero: LongSQLMetricValue = new LongSQLMetricValue(0L)
+ override def zero: LongSQLMetricValue = new
LongSQLMetricValue(initialValue)
}
private[sql] object SQLMetrics {
- def createLongMetric(sc: SparkContext, name: String): LongSQLMetric = {
- val acc = new LongSQLMetric(name)
+ def createLongMetric(
+ sc: SparkContext,
+ name: String,
+ stringValue: Seq[Long] => String,
+ initialValue: Long): LongSQLMetric = {
+ val param = new LongSQLMetricParam(stringValue, initialValue)
+ val acc = new LongSQLMetric(name, param)
sc.cleaner.foreach(_.registerAccumulatorForCleanup(acc))
acc
}
+ def createLongMetric(sc: SparkContext, name: String): LongSQLMetric = {
+ createLongMetric(sc, name, _.sum.toString, 0L)
+ }
+
+ /**
+ * Create a metric to report the size information(including total, min,
med, max) like data size,
+ * spilled size, etc.
+ */
+ def createSizeMetric(sc: SparkContext, name: String): LongSQLMetric = {
+ val stringValue = (values: Seq[Long]) => {
+ // This is a work around for
https://issues.apache.org/jira/browse/SPARK-11013
--- End diff --
nit: just put `SPARK-11013` here instead of the whole URL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
