Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8956#discussion_r42176707
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -48,6 +48,34 @@ private[sql] object ParquetFilters {
         override def inverseCanDrop(statistics: Statistics[T]): Boolean = false
       }
     
    +  object StringFilter extends Enumeration {
    +    type Mode = Value
    +    val STARTS_WITH, ENDS_WITH, CONTAINS = Value
    +  }
    +
    +  case class StringFilter(
    +    v: java.lang.String,
    +    mode: StringFilter.Mode) extends UserDefinedPredicate[Binary] with 
Serializable {
    --- End diff --
    
    We don't need to extend from `Serializable` explicitly since case classes 
are inherently serializable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to