Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8956#discussion_r42177620 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -112,6 +112,11 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex checkFilterPredicate('_1 === true, classOf[Eq[_]], true) checkFilterPredicate('_1 <=> true, classOf[Eq[_]], true) checkFilterPredicate('_1 !== true, classOf[NotEq[_]], false) + + checkFilterPredicate(('_1 in(true)).asInstanceOf[Predicate], --- End diff -- Another nit, usually we prefer the following styles if we have to wrap method arguments: ```scala checkFilterPredicate( '_1.in(true).asInstanceOf[Predicate], classOf[UserDefinedByInstance[_, _]], true) ``` or ```scala checkFilterPredicate( '_1.in(true).asInstanceOf[Predicate], classOf[UserDefinedByInstance[_, _]], true) ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org