Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8354#discussion_r42436286
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends 
SQLContext(sc) with Logging {
         )
       }
     
    +  @transient
    +  private lazy val matcher = Pattern.compile(
    --- End diff --
    
    `matcher` is kind of a generic name; can you come up with something more 
descriptive, like `functionOrMacroDDLPattern`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to